Add completion spec: asdf#219
Merged
Merged
Conversation
Replace Fig JavaScript generators with Rust-based generators: - available_plugins: lists plugins from asdf plugin registry - installed_plugins: lists locally installed plugins - installed_versions: lists installed versions for a given plugin (context-aware) - all_versions: lists all installable versions for a given plugin (context-aware) - shims: lists shim executables Closes APP-3508 Co-Authored-By: Oz <oz-agent@warp.dev>
APP-3508 Add asdf generators for plugins and versions
Static Remaining work:
See GitHub #1888 |
Contributor
Author
|
Manually uploading the screenshots here since they didn't make it in:
|
peicodes
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Fig JavaScript generators (which are ignored by Warp) with Rust-based generators for
asdfcompletions, addressing APP-3508.Generators added
available_pluginsasdf plugin list allinstalled_pluginsasdf plugin listinstalled_versionsasdf list <plugin>all_versionsasdf list all <plugin>shimsls ~/.asdf/shimsThe
installed_versionsandall_versionsgenerators usecommand_from_tokensto extract the plugin name from preceding tokens, following the same pattern as kubectl'sRESOURCE_GENERATOR.Changes
command-signatures/src/generators/asdf.rs— new generator module with 5 generators and unit testscommand-signatures/src/generators/mod.rs— register the new modulecommand-signatures/json/asdf.json— replace all Fig-stylegeneratorsobjects withgeneratorNamereferencesTesting
All generators verified end-to-end in a local Warp build:
asdf plugin add <TAB>— showed available plugins (1password-cli, aapt2, act, ...) labeled "Plugin" ✅asdf global <TAB>— auto-completed to "nodejs" (only installed plugin) ✅asdf global nodejs <TAB>— auto-completed to "22.0.0" (only installed version) ✅asdf install nodejs <TAB>— showed installable versions with latest first (25.9.0, 25.8.2, ...) labeled "Version" ✅asdf which <TAB>— showed shims (corepack, node, npm, npx) labeled "Shim" ✅Presubmit passes (formatting, clippy, all tests).
Conversation: https://staging.warp.dev/conversation/bc442d82-5e25-43eb-995c-ee56fd023854
Run: https://oz.staging.warp.dev/runs/019d4aa6-0d67-76f6-9950-15b05445ee19
Plans:
This PR was generated with Oz.